Remove clvm-traits and bump chia-bls #368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a circular dependency issue still, whenever we bump clvm-traits. Since the implementations here are for the old version, the new version is a conflict, which causes errors in chia_rs. The simplest path forward is to remove the circular dependency between repos wherever possible. So this reverts a prior change to add it.
This is a breaking change, and to implement it in chia_rs, we will have to add the implementations back, as well as a dependency on clvmr in clvm-traits. This also means that chia-bls cannot depend on clvm-traits since it would indirectly depend on itself in doing so.