update pybind and fix race for bucket init. also stress test #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13231711755Details
💛 - Coveralls |
arvidn
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
This is definitely a data race, so a good fix.
More generally, keeping global variables in a shared library is really fishy. including the mutex itself. Sometimes unexpected things happen if libraries are unloaded and reloaded but the data section being preserved. I don't think we would get in trouble for this, it's just smelly.
It would probably be better to compute this table at compile time (or as a separate pre-processing step perhaps).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pybind update from 2.11.1 to 2.13.6 to hopefully fix crash.