Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add picosha.hpp to verifier.hpp #457

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Add picosha.hpp to verifier.hpp #457

merged 1 commit into from
Oct 31, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Oct 30, 2024 •
edited
Loading

verifier.hpp uses picosha2 but didn't include it, which seemed strange and required everywhere you used verifier.hpp to have also to include picosha2.hpp. This seems backwards.

Adjust verifier.hpp to include picosha2.hpp and remove now unneeded reference from other source files.

@emlowe emlowe changed the title Cleanup some stuff Add picosha.hpp to verifier.hpp Oct 30, 2024
@emlowe emlowe requested review from fchirica and Rigidity October 30, 2024 21:07
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 11601629103

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.028%
Totals Coverage Status
Change from base Build 11599391321: 0.0%
Covered Lines: 3497
Relevant Lines: 4425
💛 - Coveralls

@emlowe emlowe marked this pull request as ready for review October 30, 2024 21:23
@emlowe emlowe merged commit 582ad09 into main Oct 31, 2024
50 checks passed
@emlowe emlowe deleted the EL.build-fixes branch October 31, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity approved these changes

@fchirica fchirica Awaiting requested review from fchirica

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emlowe @Rigidity