add bytes*.fill() helper
#761
Draft
+66
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
force-pushed
the
sized_bytes_fill_helper
branch
from
7c50e27
to
b555272
Compare
arvidn
reviewed
Oct 21, 2024
| @@ -78,6 +79,27 @@ def random( | |||
| def secret(cls: Type[_T_SizedBytes]) -> _T_SizedBytes: | |||
| return cls.random(r=system_random) | |||
|
|
|||
| @classmethod | |||
| def fill(cls: Type[_T_SizedBytes], blob: bytes, fill: bytes, align: Literal["<", ">"] = ">") -> _T_SizedBytes: | |||
| if len(blob) == cls._size: | |||
There was a problem hiding this comment.
if len(blob) > cls._size, do we want to truncate and construct cls then too?
There was a problem hiding this comment.
I am tending towards no. It seems like with these classes that truncation would be surprising. I think most use cases for this are tests where you are trying to create unique values. If your blob is too long and is truncated you hazard unexpectedly having multiple of the same value generated.
This isn't meant to be a 'format' level tool, but I will note that format just creates a larger output in this case.
Pull Request Test Coverage Report for Build 11443095297Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.