Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-899: Add Python binding to scalar_multiply #598

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented Jul 8, 2024

No description provided.

@Rigidity Rigidity changed the title Add Python binding to scalar_multiply CHIA-899: Add Python binding to scalar_multiply Jul 8, 2024
Copy link

Pull Request Test Coverage Report for Build 9842425663

Details

  • 19 of 31 (61.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 82.623%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-bls/src/public_key.rs 0 6 0.0%
crates/chia-bls/src/signature.rs 19 25 76.0%
Totals Coverage Status
Change from base Build 9842116781: -0.05%
Covered Lines: 11573
Relevant Lines: 14007

💛 - Coveralls

@Rigidity Rigidity requested a review from arvidn July 8, 2024 15:54
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have a very comprehensive test for BLS on the python side, but for new python bindings, I think it would be good to also add some simple tests in python, exercising the bindings themselves

Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proper test in rust (and maybe even a property test in a fuzzer) would be warranted

ef25f8da1e4f9c8f4d2062531ce688c040258a76543831abde774872e00af74b
"
.replace([' ', '\n'], "")
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should have a comment with a reference where this test vector comes from, or you could turn it into a property-check, to ensure the result satisfies some expected properties of scalar multiplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants