-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add all member functions to Program #291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
force-pushed
the
progran-py-binding
branch
3 times, most recently
from
October 25, 2023 12:36
9777627
to
8c5d881
Compare
Pull Request Test Coverage Report for Build 7020997868
💛 - Coveralls |
arvidn
force-pushed
the
progran-py-binding
branch
6 times, most recently
from
October 26, 2023 00:18
0048778
to
ae30aa8
Compare
arvidn
force-pushed
the
progran-py-binding
branch
from
October 28, 2023 15:05
ae30aa8
to
2371851
Compare
arvidn
commented
Oct 29, 2023
arvidn
force-pushed
the
progran-py-binding
branch
3 times, most recently
from
October 31, 2023 10:50
3b35143
to
2119e3c
Compare
arvidn
commented
Oct 31, 2023
arvidn
force-pushed
the
progran-py-binding
branch
3 times, most recently
from
November 4, 2023 11:19
3cf032d
to
3f4bf12
Compare
arvidn
force-pushed
the
progran-py-binding
branch
6 times, most recently
from
November 28, 2023 14:11
f8afe9c
to
5775fd2
Compare
…ormat.SerializedProgram
arvidn
force-pushed
the
progran-py-binding
branch
from
November 28, 2023 15:29
5775fd2
to
64d4b79
Compare
arvidn
commented
Nov 30, 2023
arvidn
commented
Nov 30, 2023
AmineKhaldi
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matching
chia.types.blockchain_format.SerializedProgram
.The main challenge in this PR is to mimic the
Program.to()
of the python version. This converts arbitrary python objects into a CLVM structure, to be passed as arguments to programs. The rust implementation of this isclvm_convert()
.The python implementation can be found here:
https://github.com/Chia-Network/clvm/blob/main/clvm/SExp.py#L59-L115
and here:
https://github.com/Chia-Network/clvm/blob/main/clvm/SExp.py#L38-L55
There are tests for all types supported in this conversion on the rust side, as well as some testing to make sure the rust implementation behaves the same as the python one (
test_program_fidelity.py
)