Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore errors in daemon plotter process cleanup #19025

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Dec 10, 2024

Based on some CI failures, the error indicates a key error on the self.services dictionary during this finally block.

(see https://github.com/Chia-Network/chia-blockchain/actions/runs/12263577030/job/34215480215?pr=19016)

Unclear what timing or code path creates this discrepancy, but I believe we can safely ignore any keyerrors when removing the process tracking. The process will still be waited for, but if the entire tracking list doesn't exist there isn't anything to remove.

Unclear if this is masking some other problem with the test however, so there may be something else hiding behind this. But I think it should be fixed regardless.

@emlowe emlowe requested a review from a team as a code owner December 10, 2024 22:21
@emlowe emlowe added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog CI CI changes Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Dec 10, 2024
@emlowe emlowe requested a review from altendky December 10, 2024 22:58
@emlowe emlowe changed the title ignore errors in general cleanup ignore errors in daemon plotter process cleanup Dec 10, 2024
@pmaslana pmaslana merged commit 8a56aa1 into main Dec 18, 2024
365 of 366 checks passed
@pmaslana pmaslana deleted the EL.daemon-plotter-test-flakes branch December 18, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI changes Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants