Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-2022: Fix problems with startup timing and the Datalayer processing loop #19014

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Dec 10, 2024

When starting datalayer and wallet together (this is the default behaviour), the datalayer processing loop can get network errors when quering the wallet for owned stores. These errors have to be ignored in the main DL processing loop otherwise the loop will exit preventing stores from being processed correctly until DL is restarted.

Previously only ValueError exceptions were caught. New code catches all exceptions with some different logging.

@emlowe emlowe requested a review from a team as a code owner December 10, 2024 18:12
@emlowe emlowe added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Dec 10, 2024
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also log.exception("...") which is pretty handy

@altendky
Copy link
Contributor

heh, and chia.util.log_exceptions.log_exceptions()

@pmaslana pmaslana merged commit beff6e2 into main Dec 12, 2024
362 of 363 checks passed
@pmaslana pmaslana deleted the EL.DL-CHIA-2022 branch December 12, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants