Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert test_change_pools to WalletTestFramework #18996

Merged
merged 4 commits into from
Dec 12, 2024
Merged

convert test_change_pools to WalletTestFramework #18996

merged 4 commits into from
Dec 12, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Dec 6, 2024 •
edited
Loading

Convert flaky test_change_pools test to newer WalletTestFramework

Also limit the pool RPC tests to single consensus mode

@emlowe emlowe added CI CI changes Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Dec 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

File Coverage Missing Lines
chia/_tests/pools/test_pool_rpc.py 98.1% lines 1029
Total Missing Coverage
57 lines Unknown 98%

@emlowe emlowe requested review from Quexington and altendky December 6, 2024 23:24
@emlowe emlowe marked this pull request as ready for review December 6, 2024 23:24
@emlowe emlowe requested a review from a team as a code owner December 6, 2024 23:24
Quexington
Quexington approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Quexington Quexington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting for posterity that this is an area where having a hook in WalletTestFramework to check additional states beyond balances would be nice.

@altendky altendky removed their request for review December 11, 2024 15:43
@pmaslana pmaslana merged commit 4db4cd9 into main Dec 12, 2024
561 of 564 checks passed
@pmaslana pmaslana deleted the EL.change-pools branch December 12, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quexington Quexington Quexington approved these changes

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog CI CI changes coverage-diff Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emlowe @arvidn @Quexington @pmaslana