Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localize signer cmd import loop #18986

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −3
Draft

localize signer cmd import loop #18986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6246743
localize signer cmd import loop
altendky Dec 4, 2024
2a0c6c7
and the signer group can actually be turned inside out too
altendky Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions chia/cmds/chia.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,6 @@ def run_daemon_cmd(ctx: click.Context, wait_for_unlock: bool) -> None:


def main() -> None:
import chia.cmds.signer # noqa

cli()


Expand Down
2 changes: 1 addition & 1 deletion chia/cmds/signer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def _clear_screen() -> None:
os.system("cls" if os.name == "nt" else "clear")


@wallet_cmd.group("signer", help="Get information for an external signer")
@click.group("signer", help="Get information for an external signer")
def signer_cmd() -> None:
pass # pragma: no cover

Expand Down
11 changes: 11 additions & 0 deletions chia/cmds/wallet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,17 @@ def wallet_cmd(ctx: click.Context) -> None:
pass


# TODO: must come after the definition above because of an import loop. the command
# class framework should be expanded to support definition without a group to be a
# member of and later attachment to a group using standard click mechanisms.


import chia.cmds.signer # noqa: E402

# TODO: ignoring as i'm guessing this is tied to the import loop
wallet_cmd.add_command(chia.cmds.signer.signer_cmd) # type: ignore[has-type]


@wallet_cmd.command("get_transaction", help="Get a transaction")
@click.option(
"-wp",
Expand Down
Loading