-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
claim ownership of /opt/chia
in the RPM
#16980
Conversation
This results in the directory being removed on package removal. When this doesn't happen we have observed odd behavior with `None` versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely be doing this
Pull Request Test Coverage Report for Build 7065727881Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Purpose:
This results in the directory being removed on package removal. When this doesn't happen we have observed odd behavior with
None
versions.Current Behavior:
New Behavior:
Testing Notes:
Tests are being added in #16979. The presently pass for
.deb
at https://github.com/Chia-Network/chia-blockchain/actions/runs/7054691144/job/19204269927?pr=16979 and fail for.rpm
at https://github.com/Chia-Network/chia-blockchain/actions/runs/7054691163/job/19204407929?pr=16979.This fix and the test pr are being combined at #16981. Results at https://github.com/Chia-Network/chia-blockchain/actions/runs/7054950782/job/19204621540?pr=16981 are... well, good for the CLI package. Need to look into removal of the GUI package.
Draft For: