Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claim ownership of /opt/chia in the RPM #16980

Merged
merged 11 commits into from
Dec 4, 2023
Merged

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Dec 1, 2023

Purpose:

This results in the directory being removed on package removal. When this doesn't happen we have observed odd behavior with None versions.

Current Behavior:

New Behavior:

Testing Notes:

Tests are being added in #16979. The presently pass for .deb at https://github.com/Chia-Network/chia-blockchain/actions/runs/7054691144/job/19204269927?pr=16979 and fail for .rpm at https://github.com/Chia-Network/chia-blockchain/actions/runs/7054691163/job/19204407929?pr=16979.

This fix and the test pr are being combined at #16981. Results at https://github.com/Chia-Network/chia-blockchain/actions/runs/7054950782/job/19204621540?pr=16981 are... well, good for the CLI package. Need to look into removal of the GUI package.

Draft For:

This results in the directory being removed on package removal.  When this doesn't happen we have observed odd behavior with `None` versions.
@altendky altendky requested a review from a team as a code owner December 1, 2023 01:43
@altendky altendky added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Dec 1, 2023
@altendky altendky marked this pull request as draft December 1, 2023 02:47
Copy link
Contributor

@TheLastCicada TheLastCicada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely be doing this

@altendky altendky marked this pull request as ready for review December 4, 2023 18:05
Copy link

Pull Request Test Coverage Report for Build 7065727881

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 90.413%

Totals Coverage Status
Change from base Build 7049720056: -0.02%
Covered Lines: 93732
Relevant Lines: 103630

💛 - Coveralls

@cmmarslender cmmarslender merged commit 1964593 into release/2.1.2 Dec 4, 2023
576 checks passed
@cmmarslender cmmarslender deleted the rpm_owns_opt_chia branch December 4, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants