Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep latest_coin_id in GUI NFT signature response so it is same as RPC response #2403

Conversation

markelrod
Copy link
Contributor

No description provided.

@markelrod markelrod requested a review from a team as a code owner June 15, 2024 06:38
@markelrod markelrod linked an issue Jun 15, 2024 that may be closed by this pull request
Copy link
Contributor

@ChiaMineJP ChiaMineJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched for the reason why latest_coin_id was removed in the past but found no clue.
My guess is that latest_coin_id isn't referred by the signature verification process so the author might feel it's useless. (This means latest_coin_id can be forged and amateur easily believes it's a true coin_id)

Maybe this in-verifiability is important. latest_coin_id cannot be directly verified by the signature.
Imagine there is a signature file in the internet and someone tries to verify the signature file which contains forged latest_coin_id.
If the person tries to verify the signature file with forged latest_coin_id with GUI, it might verify the sig successfully since forged latest_coin_id is nothing to do with the signature.

@Starttoaster Starttoaster merged commit b43e285 into main Jun 27, 2024
9 checks passed
@Starttoaster Starttoaster deleted the mbe/2395-bug-create-signature-with-nft-gui-vs-cli-diferent-response branch June 27, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] "Create Signature with nft" GUI vs CLI diferent response
4 participants