Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkpoint: into main from release/2.2.0 @ abb10ab4405dc0f845b912c690594458284ae21e #2281

Conversation

AmineKhaldi
Copy link
Contributor

Source hash: abb10ab
Remaining commits: 3

ChiaMineJP and others added 3 commits February 10, 2024 01:38
@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog checkpoint_merge labels Feb 23, 2024
@emlowe
Copy link
Contributor

emlowe commented Feb 23, 2024

There was some problem with these changes in the release branch and I'm not sure we want to checkpoint them back into main - checking with @ChiaMineJP

@emlowe emlowe requested a review from ChiaMineJP February 23, 2024 18:20
@AmineKhaldi
Copy link
Contributor Author

There was some problem with these changes in the release branch and I'm not sure we want to checkpoint them back into main - checking with @ChiaMineJP

We'll end up naturally checkpointing 82168f1 which gets us where we want to be. Am I missing something?

@emlowe
Copy link
Contributor

emlowe commented Feb 23, 2024

It's probably me and not you :-)

@altendky
Copy link
Contributor

My understanding was that we would checkpoint everything but no-op the removal in 82168f1. Then release does not have the feature and main has the feature, bugs and all, and it can be fixed there.

As a detail, everything gets checkpointed. The only variation is how you do it. Like making the diff empty when we checkpoint 82168f1 since that change (removal) is meant only for the release branch. But we have to record that intent in git.

@emlowe emlowe merged commit 1360693 into main Feb 26, 2024
9 checks passed
@emlowe emlowe deleted the checkpoint/main_from_release_2.2.0_abb10ab4405dc0f845b912c690594458284ae21e branch February 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog checkpoint_merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants