Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed installation path issue #2277

Closed
wants to merge 8 commits into from
Closed

Conversation

ChiaMineJP
Copy link
Contributor

@ChiaMineJP ChiaMineJP commented Feb 20, 2024

On Windows, if there is a space in folder name in installatin path, GUI fails to launch daemon child process.
This PR double-quotes the path to daemon to prevent this issue.
Confirmed to work on Windows 10, M1 MacOS.

This fixes this issue Chia-Network/chia-blockchain#17579

Todo

Check the PRs below are merged into main

@ChiaMineJP ChiaMineJP added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Feb 20, 2024
@ChiaMineJP ChiaMineJP self-assigned this Feb 20, 2024
zsolt-dev
zsolt-dev previously approved these changes Feb 20, 2024
@ChiaMineJP ChiaMineJP changed the base branch from release/2.2.0 to main February 21, 2024 11:44
@ChiaMineJP ChiaMineJP dismissed zsolt-dev’s stale review February 21, 2024 11:44

The base branch was changed.

@ChiaMineJP ChiaMineJP closed this Feb 21, 2024
@ChiaMineJP ChiaMineJP reopened this Feb 21, 2024
@ChiaMineJP
Copy link
Contributor Author

ChiaMineJP commented Feb 21, 2024

@zsolt-dev I changed the baes branch to main since Keep services running background... feature was removed from 2.2.0. Please review this again!
Sorry please wait until main branch takes changes from release/2.2.0 branch.

@ChiaMineJP ChiaMineJP marked this pull request as draft February 21, 2024 11:50
@ChiaMineJP
Copy link
Contributor Author

Closing this issue because the original issue was resolved.

@ChiaMineJP ChiaMineJP closed this Apr 3, 2024
@ChiaMineJP ChiaMineJP deleted the cmj.fix-daemon-not-launch branch April 3, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants