Update jsbindings.cpp #455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8410371840Details
💛 - Coveralls |
ChiaMineJP
reviewed
Mar 24, 2024
There was a problem hiding this comment.
I'd suggest to build it as described in
https://github.com/Chia-Network/bls-signatures/blob/main/js-bindings/README.md#build
|
This can't be correct - you change the G2Element to use the G1Element generator? |
Yes indeed its wrong was supposed to update the G1Element to use the G1Element generator. But hadn‘t got round to then building it and doing it correctly. As when looking at the current implementation the g1 generator returns the G2Element in the types which i assume is incorrect ? |
|
Location in the generated types as seen here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed in the correct place now.