fix(query): added cases for Azure App Service resources: azurerm_linux_web_app and azurerm_windows_web_app (Issue #7719)

[tplisson]

Closes #7719

Reason for Proposed Changes

• This pull request updates the existing query related to Issue query(Terraform): false negatives for App Service FTPS Enforce Disabled #7719, and addresses the lack of support for the latest Terraform Azure App Service resources: azurerm_linux_web_app and azurerm_windows_web_app. Only the legacy resource azurerm_app_service was currently taken into account, although it is now outdated and deprecated since version 3.0 of the AzureRM provider.

Proposed Changes

• Query updated to detect misconfigurations for resources: azurerm_linux_web_app and azurerm_windows_web_app
• Test cases added/updated to validate the additional cases
• Documentation updated
• Ensured compatibility with existing query structure and naming conventions.

I submit this contribution under the Apache-2.0 license.

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
20838717	Triggered	Generic Password	8dc6e38	assets/queries/azureResourceManager/sql_server_database_with_alerts_disabled/test/negative8.bicep	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[cx-artur-ribeiro]

Hi @tplisson,
Thanks for actively contributing to KICS! 🎉

After reviewing the official Terraform documentation, I agree that we currently do not support the latest Terraform Azure App Service resources you mentioned.
Regarding your proposed changes: the query looks good, and you also added the necessary test coverage, great work!

I just have one request: could you please revert the changes you made to the Terraform queries documentation? We have an automated action that updates this documentation, so we don’t need to manually add new test cases there.

Once that’s done, I’ll approve the PR and move forward with the necessary next steps to ensure your changes are included in the next KICS release (or as soon as possible).

[tplisson]

Great! Thanks @cx-artur-ribeiro for your great reactivity.
I have reverted the changes made to the Terraform queries documentation.

[cx-artur-ribeiro]

Great work @tplisson, thanks for your contribution!

[tplisson]

@cx-andre-pereira @cx-artur-ribeiro
The failed GitGuardian Security Checks is not related to our query, so I'm not sure how to fix this. Is it be okay to ignore it and approve the merge, please ?

[cx-artur-ribeiro]

Hey @tplisson,
We are just waiting for the QA proccess to finish so we can merge the pull request.
Don't worry about the GitGuardian checks, I will skip if necessary (false positive).

You will be notified once the pull request is merged.
Thanks!

[cx-artur-ribeiro]

LGTM