-
Couldn't load subscription status.
- Fork 348
feat(log): add results and queries summaries to log #7606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 4266022 | Triggered | Generic Password | b284763 | assets/queries/cloudFormation/aws/amplify_app_basic_auth_config_password_exposed/test/negative7.yaml | View secret |
| 9419039 | Triggered | Username Password | b284763 | assets/queries/cloudFormation/aws/amplify_branch_basic_auth_config_password_exposed/test/positive6.json | View secret |
| 20838717 | Triggered | Generic Password | ef4964c | assets/queries/azureResourceManager/sql_server_database_with_alerts_disabled/test/negative8.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…marx/kics into add-results-details-to-log
…marx/kics into add-results-details-to-log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cx-laura-rodrigues,
First of all, thanks for the (well-needed) improvements to KICS logs!
I left three quality-of-life suggestions, but from my side, that’s it!
I’ll contact the other maintainers to get their opinions on these additions, especially the SetBoolFlag function.
Well done adding test coverage to all the code 😃
Co-authored-by: Artur Ribeiro <[email protected]>
Co-authored-by: Artur Ribeiro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cx-laura-rodrigues please check my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work done Laura, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution 🙌
f03e047








Reason for Proposed Changes
Proposed Changes
I submit this contribution under the Apache-2.0 license.