Skip to content

Conversation

@cx-laura-rodrigues
Copy link
Contributor

Reason for Proposed Changes

  • Adding key details about queries results to the log

Proposed Changes

  • Added Queries Summary to log printer
  • Added the existing Results Summary to the log

I submit this contribution under the Apache-2.0 license.

@cx-laura-rodrigues cx-laura-rodrigues requested a review from a team as a code owner July 30, 2025 11:10
@github-actions github-actions bot added community Community contribution feature request Community: new feature request query New query feature labels Jul 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025

kics-logo

KICS version: v2.1.13

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@gitguardian
Copy link

gitguardian bot commented Aug 6, 2025

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
4266022 Triggered Generic Password b284763 assets/queries/cloudFormation/aws/amplify_app_basic_auth_config_password_exposed/test/negative7.yaml View secret
9419039 Triggered Username Password b284763 assets/queries/cloudFormation/aws/amplify_branch_basic_auth_config_password_exposed/test/positive6.json View secret
20838717 Triggered Generic Password ef4964c assets/queries/azureResourceManager/sql_server_database_with_alerts_disabled/test/negative8.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cx-laura-rodrigues,
First of all, thanks for the (well-needed) improvements to KICS logs!

I left three quality-of-life suggestions, but from my side, that’s it!
I’ll contact the other maintainers to get their opinions on these additions, especially the SetBoolFlag function.

Well done adding test coverage to all the code 😃

Co-authored-by: Artur Ribeiro <[email protected]>
Copy link
Contributor

@cx-rui-araujo cx-rui-araujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cx-laura-rodrigues please check my comments

Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work done Laura, LGTM!

cx-rui-araujo
cx-rui-araujo previously approved these changes Oct 7, 2025
Copy link
Contributor

@cx-rui-araujo cx-rui-araujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution 🙌

@cx-rui-araujo cx-rui-araujo dismissed stale reviews from cx-artur-ribeiro and themself via f03e047 October 14, 2025 16:59
@cx-laura-rodrigues cx-laura-rodrigues merged commit ea64fdf into master Oct 15, 2025
26 checks passed
@cx-laura-rodrigues cx-laura-rodrigues deleted the add-results-details-to-log branch October 15, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Community contribution feature request Community: new feature request query New query feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants