Skip to content

fix(query): support deprecated enable_https_traffic_only and https_traffic_only_enabled fields #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 30, 2025
Merged

fix(query): support deprecated enable_https_traffic_only and https_traffic_only_enabled fields #7461

merged 14 commits into from
Jun 30, 2025

Conversation

cx-artur-ribeiro
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro commented May 7, 2025 •
edited
Loading

Closes #7239

Reason for Proposed Changes

Proposed Changes

  • Support both enable_https_traffic_only and https_traffic_only_enabled fields;
  • Update test cases to reflect both param naming;

I submit this contribution under the Apache-2.0 license.

@cx-artur-ribeiro cx-artur-ribeiro self-assigned this May 7, 2025
@cx-artur-ribeiro cx-artur-ribeiro added bug Something isn't working query New query feature terraform Terraform query accuracy Query accuracy (FN and FP) labels May 7, 2025
@github-actions github-actions bot removed the bug Something isn't working label May 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

kics-logo

KICS version: v2.1.7

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-artur-ribeiro cx-artur-ribeiro changed the title fix(query): rename deprecated enable_https_traffic_only to https_traffic_only_enabled fix(query): support deprecated enable_https_traffic_only and https_traffic_only_enabled fields Jun 23, 2025
@cx-artur-ribeiro cx-artur-ribeiro marked this pull request as ready for review June 23, 2025 11:48
@cx-artur-ribeiro cx-artur-ribeiro requested a review from a team as a code owner June 23, 2025 11:48
@cx-miguel-silva cx-miguel-silva merged commit 4f3ba23 into master Jun 30, 2025
26 checks passed
@cx-miguel-silva cx-miguel-silva deleted the AST-92897 branch June 30, 2025 14:43
@cx-artur-ribeiro cx-artur-ribeiro mentioned this pull request Jul 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-miguel-silva cx-miguel-silva cx-miguel-silva approved these changes

Assignees

@cx-artur-ribeiro cx-artur-ribeiro

Labels
accuracy Query accuracy (FN and FP) query New query feature terraform Terraform query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(terraform): param enable_https_traffic_only now renamed to https_traffic_only_enabled
2 participants
@cx-artur-ribeiro @cx-miguel-silva