fix: refactor

Chat-Your-Way · Oct 11, 2024 · a773bd3 · a773bd3
1 parent befd7b6
commit a773bd3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/main/java/com/chat/yourway/service/EmailMessageFactoryService.java b/src/main/java/com/chat/yourway/service/EmailMessageFactoryService.java
@@ -14,12 +14,16 @@
 @Slf4j
 public class EmailMessageFactoryService {
   public EmailMessageDto generateEmailMessage(EmailMessageInfoDto emailMessageInfoDto) {
-    String path = emailMessageInfoDto.path();
-    UUID uuidToken = emailMessageInfoDto.uuidToken();
-    EmailMessageType emailMessageType = emailMessageInfoDto.emailMessageType();
-    String link = generateLink(path, uuidToken, emailMessageType);
+    final var path = emailMessageInfoDto.path();
+    final var uuidToken = emailMessageInfoDto.uuidToken();
+    final var emailMessageType = emailMessageInfoDto.emailMessageType();
+    final var link = generateLink(path, uuidToken, emailMessageType);
+
     log.info("Generated link: {}", link);
-    String messageBody = String.format(emailMessageType.getMessageBody(), emailMessageInfoDto.username(), link);
+
+    final var messageBody = String.format(
+            emailMessageType.getMessageBody(), emailMessageInfoDto.username(), link
+    );
 
     return new EmailMessageDto(emailMessageInfoDto.email(), emailMessageType.getSubject(), messageBody);
   }

diff --git a/src/main/java/com/chat/yourway/service/EmailSenderService.java b/src/main/java/com/chat/yourway/service/EmailSenderService.java
@@ -18,7 +18,7 @@
 public class EmailSenderService {
 
   @Value("${spring.mail.username}")
-  private String emailAddressFrom;
+  private final String emailAddressFrom;
   private final JavaMailSender javaMailSender;
 
   @Async