Charts/issues/5197 - fixed host app crash by adding a check before ca… #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naveen-C-Ramachandrappa
approved these changes
Oct 5, 2024
|
@Naveen-C-Ramachandrappa thanks for the approval. Do you know when we can expect the PR to be merged in? Thanks a lot 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
Link to issue: #5197
Goals ⚽
Fix the crash of the host app from within the library code whenever you get in a situation where the CGFloat calculated in the renderers' isDrawingValuesAllowed function are equal to CGFloat.infinity or to CGFloat.nan, as type casting those causes a crash.
Implementation Details 🚧
Honestly it's pretty self explanatory and it's rather a dumb-value check, nothing crazy or complicated. The issue explains it all already.
Testing Details 🔍
I didn't add any tests, as there's no point in testing something that i added because if fails at the compiler level so i don't think any tests are required, but please let me know.