-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posibility to add Corner Radius for rounded bars in bar chart #5163
base: master
Are you sure you want to change the base?
Conversation
@crash481 found an interesting "bug" if a chart has both negative and positive values. If you specify topLeft and topRight we end up with this, which is totally expected but makes it less useful on these types of charts. So in these cases we can round all corners. Unless we find a way to add the rounding parameter to the |
Yes, it needs to check if value is negative and invert values. |
2047fe6
to
a29a1a1
Compare
Thanks so much! I'll try it out. The highlighting works great btw. Now if your can also add rounded corners to the pie chart... 😊 |
f527af1
to
1b9bc5b
Compare
@crash481 Works great |
@crash481 Noticed a small bug: when the |
@crash481 were you able to figure out the issue above? |
public var cornerRadius: CGFloat = 0.0 | ||
|
||
/// array of corners to be rounded | ||
open var roundedCorners: UIRectCorner = [] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to make roundedCorners
open?
Issue 🔗
Many years people needs to fork this repo to implement rounded bars in bar chart.
In pull requests exists also fixing same issue, but my implementation is more configurable
How to use: