Open
Conversation
rsukumar-cpi-zz
requested review from
abotkin-cpi and
mgorkani-cpi
as code owners
abotkin-cpi
suggested changes
Aug 26, 2019
Contributor
abotkin-cpi
left a comment
abotkin-cpi
left a comment
There was a problem hiding this comment.
We should likely rename Sample-App into xcparse-visualizer or something snazzier. We're using it for tests of the XCResults but other folks will likely be installing it just to visualize the XCResult file.
Also, it looks like we're using an xcparse.framework? How are we managing our dependency on it? Seems like we should write the visualizer app into the Package.swift file in order to have it depend on the XCParseCore framework that we use within the xcparse command line tool.
…les to support xcparse-visualizer app's functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description:
Added macOS sample app to visualize the models contained in xcresult test reports. Also created several test plans with multiple configurations to generate different xcresult files for analysis. Added xcparser framework used with sample app.
Test Plan/Testing Performed:
App runs with minimum required functionality.