Add script for cleaning up jupyter volumes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently just logs information about volumes that should be cleaned up.
msherman64
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
this looks good to me,
but we'll need to be careful about where we leave keycloak admin credentials.
it would also be nice to have some minimal unit tests which mock + describe the API responses we depend on here, e.g. "keycloak will show something that looks like X"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently just logs information about volumes that should be cleaned up. Config is handled via environment variables as it's easiest to config the kubernetes job that way.
For the kubernetes job spec, see ChameleonCloud/jupyterhub-kubernetes#4
To simplify the kubernetes job, we probably should build a container image in this repo directly that it can consume.