fix: resets audio ui when permission is denied#2771
Open
eiseleMichael wants to merge 1 commit intoChainlit:mainfrom
Open
fix: resets audio ui when permission is denied#2771eiseleMichael wants to merge 1 commit intoChainlit:mainfrom
eiseleMichael wants to merge 1 commit intoChainlit:mainfrom
Conversation
eiseleMichael
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
dosubot
bot
added
size:M
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
This PR is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
Contributor
Author
|
:bump: Is there anything I can do to help with the review process? |
eiseleMichael
force-pushed
the
fix/audio-stream-freeze-denied-permissions
branch
from
7096daf to
482d528
Compare
github-actions
bot
removed
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps connection to microphone in a try/catch block to automatically reset ui when permission is not granted.
Without this fix, the UI remains in loading state until the window is refreshed.
Summary by cubic
Prevents the audio UI from freezing when microphone permission is denied by catching setup errors and resetting the session. If access is blocked, audio capture is cleaned up, the stream ends, and the UI returns to idle.
Written for commit 482d528. Summary will update on new commits.