refactor: query ShufflingCache for shuffling data #8743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoeths
changed the title
Contributor
Summary of ChangesHello @twoeths, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the handling of beacon committee and attestation data queries. It centralizes the underlying logic into a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a significant refactoring to query shuffling data from ShufflingCache instead of EpochCache. The changes are spread across multiple packages and appear to be well-implemented, aligning with the goal of migrating away from EpochCache methods. I've included a couple of suggestions to enhance code quality: one to address code duplication by introducing a helper method, and another to correct a minor typo in an error code for better consistency. Overall, the changes look good.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
force-pushed
the
te/query_shuffling_cache
branch
from
0704cbd to
ceaf192
Compare
…onCommittee(s) in shufflingUtils.ts
twoeths
force-pushed
the
te/query_shuffling_cache
branch
from
336e6b9 to
903153a
Compare
Contributor
Author
|
found a good fix to populate |
nflaig
reviewed
Jan 23, 2026
Member
nflaig
left a comment
nflaig
left a comment
There was a problem hiding this comment.
looks good overall, just a few nits
packages/beacon-node/test/perf/chain/opPools/aggregatedAttestationPool.test.ts
Outdated
Show resolved
Hide resolved
| }); | ||
|
|
||
| // in forky condition, make sure to populate ShufflingCache with regened state | ||
| // otherwise it's failed to get indexed attestations from shuffling cache later |
Member
There was a problem hiding this comment.
did this always happen or just in certain edge cases?
Suggested change
| // otherwise it's failed to get indexed attestations from shuffling cache later | |
| // otherwise it may fail to get indexed attestations from shuffling cache later |
Contributor
Author
There was a problem hiding this comment.
it happens on super forky condition, specifically in fork_choice spec_tests
ShufflingCache is designed to store only 4 epochs, say epoch 4, 5, 6, 7, then it reorg to epoch 3, then we cannot use ShufflingCache to get indexed attestations of below call (because Shufflings of epoch 3 was removed)
to make it safe we can just process regened states right after getPreState call (there are 2 of them)
that was the scenario in #8743 (comment)
Member
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase to replace direct calls to EpochCache methods with calls to the ShufflingCache for retrieving shuffling data. This change is motivated by the migration to native state-transition, which eliminates the ability to query EpochCache methods directly. The changes involve modifying several files to use the ShufflingCache for methods like getIndexedAttestation(), getAttestingIndices(), getBeaconCommittee(), and getBeaconCommittees().
nflaig
approved these changes
Jan 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8743 +/- ##
============================================
+ Coverage 52.11% 52.13% +0.01%
============================================
Files 848 848
Lines 64252 64178 -74
Branches 4735 4730 -5
============================================
- Hits 33488 33457 -31
+ Misses 30695 30652 -43
Partials 69 69 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Closes #8655
blocked by #8721