Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use subnet request mechanism for subnet sampling strategy #7274

Open
wants to merge 5 commits into
base: peerDAS
Choose a base branch
from

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Dec 3, 2024

Motivation

  • stablize peers for subnet sampling strategy
  • more peers metric added

Description

  • use our subnet request mechanism for column subnets
    • if a peer does not have any column subnets that we need, do not dial it
    • in average, a column subnet has 3.125 peer. I made default targetColumnSubnetPeers = 6 which make it easy to achieve after a few heartbeats but this could be changed with a newly added cli flag with the same name
    • this mechanism replace onlyConnect* flags
  • more metrics, this answer some questions:
    • what are column subnets we're sampling, how many peers per subnet?
    • number of column subnets requested, how many peers requested
    • reason for not dialing a peer
    • csc value of each ENR

@twoeths twoeths changed the title Te/peerdas prioritize peers feat: use subnet request mechanism for subnet sampling strategy Dec 3, 2024
@twoeths twoeths marked this pull request as ready for review December 10, 2024 10:04
@twoeths twoeths requested a review from a team as a code owner December 10, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant