Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(dot/parachain): Add CompactStatement type #4424

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

axaysagathiya
Copy link
Contributor

@axaysagathiya axaysagathiya commented Dec 19, 2024

Changes

  • introduced CompactStatement and compactStatementInner types. We will only deal with CompactStatement in other codebases. compactStatementInner is only used for encoding/decoding of CompactStatement, which is why it's not exported.
  • implemented MarshalSCALE and UnmarshalSCALE methods to have custom encoding/decoding logic for CompactStatement.
  • also updated the sign logic of statementVDT to encode the data properly before signing.

Tests

go test ./dot/parachain/types/... -v

Issues

Closes #4422

@axaysagathiya axaysagathiya changed the title Feat(dot/parachain): Add CompactStatement varying datatype Feat(dot/parachain): Add CompactStatement type Dec 20, 2024
@axaysagathiya axaysagathiya marked this pull request as ready for review December 20, 2024 11:23
dot/parachain/types/statement.go Outdated Show resolved Hide resolved
dot/parachain/types/statement.go Show resolved Hide resolved
@axaysagathiya axaysagathiya merged commit dd1530e into feat/parachain Dec 20, 2024
22 checks passed
@axaysagathiya axaysagathiya deleted the axay/parachain/compact-statement-vdt branch December 20, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants