feat(prospective-parachains): handle GetMinimumRelayParents signal
#4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielDDHM
requested review from
EclesioMeloJunior,
jimjbrettj and
timwu20
as code owners
EclesioMeloJunior
approved these changes
Dec 3, 2024
…t_minimum_relay_parents_signal
|
should wait the merge of branch of #4337 |
Co-authored-by: Eclésio Junior <[email protected]>
EclesioMeloJunior
changed the title
GetMinimumRelayParents signal
haikoschol
requested changes
Dec 4, 2024
dot/parachain/prospective-parachains/prospective-parachains_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/prospective-parachains/prospective-parachains_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/prospective-parachains/prospective-parachains_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/prospective-parachains/prospective-parachains_test.go
Outdated
Show resolved
Hide resolved
haikoschol
requested changes
Dec 5, 2024
dot/parachain/prospective-parachains/prospective-parachains_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/prospective-parachains/prospective-parachains_test.go
Outdated
Show resolved
Hide resolved
haikoschol
approved these changes
Dec 5, 2024
EclesioMeloJunior
requested changes
Dec 5, 2024
dot/parachain/prospective-parachains/prospective-parachains_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/prospective-parachains/prospective-parachains_test.go
Outdated
Show resolved
Hide resolved
…t_minimum_relay_parents_signal
|
Currently waiting for #4337 |
…t_minimum_relay_parents_signal
…t_minimum_relay_parents_signal
…t_minimum_relay_parents_signal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
implements AnswerMinimumRelayParentsRequest
Tests
Unit Tests: Core logic is tested in isolation using testify for assertions
go test -tags integration github.com/ChainSafe/gossamerIssues
GetMinimumRelayParentssignal #4312