Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pkg/finality-grandpa): fix tests by closing network goroutines #4319

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix(pkg/finality-grandpa): fix tests by closing network goroutines #4319

merged 1 commit into from
Nov 6, 2024

Conversation

timwu20
Copy link
Contributor

@timwu20 timwu20 commented Nov 6, 2024 •
edited
Loading

Changes

  • Closes network goroutines in the test network.
  • Should fix the flakiness in the grandpa tests.

Tests

go test -tags integration github.com/ChainSafe/gossamer

EclesioMeloJunior
EclesioMeloJunior approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small comment/question

pkg/finality-grandpa/environment_test.go Show resolved Hide resolved
@timwu20 timwu20 merged commit 6a30228 into development Nov 6, 2024
24 checks passed
@timwu20 timwu20 deleted the tim/fix-grandpa-tests branch November 6, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@haikoschol haikoschol haikoschol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timwu20 @haikoschol @EclesioMeloJunior