Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parachain/collation-protocol): handle peer view change #4307

Merged

Conversation

kishansagathiya
Copy link
Contributor

  • On receiving peer view change, update our view of that peer, clearing all the advertisements that are no longer in current view.
  • This commit also moves View to types package to be reused by multiple subsystems

Changes

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Fixes #4155

- On receiving peer view change, update our view of that peer, clearing all the advertisements
that are no longer in current view.
- This commit also moves View to types package to be reused by multiple subsystems
dot/parachain/collator-protocol/validator_side.go Outdated Show resolved Hide resolved
dot/parachain/collator-protocol/validator_side.go Outdated Show resolved Hide resolved
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dot/parachain/types/view.go Show resolved Hide resolved
@kishansagathiya kishansagathiya merged commit 075322c into feat/parachain Nov 11, 2024
21 of 22 checks passed
@kishansagathiya kishansagathiya deleted the feat/kishan/collation-protocol-peer-view-change branch November 11, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants