test(dot): fix two tests on MacOS #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haikoschol
requested review from
EclesioMeloJunior,
jimjbrettj,
timwu20 and
kishansagathiya
as code owners
jimjbrettj
approved these changes
Oct 30, 2024
EclesioMeloJunior
approved these changes
Oct 30, 2024
haikoschol
removed request for
dimartiro,
timwu20,
edwardmack,
kishansagathiya and
axaysagathiya
Before this change, Test_createSystemService and Test_createRuntimeStorage were failing on MacOS due to differences to Linux wrt the unlinkat syscall. Closes #4283
haikoschol
force-pushed
the
haiko/fix-tests-4283
branch
from
52ad037
to
aeda566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Properly initialize and shut down
state.ServiceinTest_createSystemServiceandTest_createRuntimeStoragein thedotpackage.Tests
on MacOS:
Issues
Closes #4283