-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): update default min-peers value to 5 to match documentation #4257
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #4257 +/- ##
===============================================
+ Coverage 50.51% 53.52% +3.01%
===============================================
Files 230 297 +67
Lines 29006 30634 +1628
===============================================
+ Hits 14653 16398 +1745
+ Misses 12856 12348 -508
- Partials 1497 1888 +391 |
@raj921 Thanks for the contribution! Don't worry about the failing checks. Please sign the CLA and we'll merge this. |
sry for the delay sign in |
815c394
to
a8ec01e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
The --min-peers flag was documented to have a default value of 5, but the code had it set to 0. This commit changes the default value in the code to 5, aligning with the documentation and improving user experience.
a8ec01e
to
5b2d7b0
Compare
Changes
--min-peers
flag to 5 in the code to align with the documented default.Tests
To verify the changes, you can run the integration tests: