(dot/parachain): handle view update message for receiver side of the network bridge #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over the network through collation and validation protocol, as part of WireMessage we could get a PeerMessage or a ViewUpdate. ViewUpdate tells us about latest blocks (heads) and finalized number with our peers. We are supposed to be update our peer data with these views. This commit, reads ViewUpdate from both collation and validation protocol and handles them inside network bridge by updating our peer data. Later, it sends that view to other subsystems so that each subsystem can update their view too. Fixes #3864
kishansagathiya
requested review from
EclesioMeloJunior,
jimjbrettj and
timwu20
as code owners
haikoschol
approved these changes
Oct 15, 2024
axaysagathiya
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Over the network through collation and validation protocol, as part of WireMessage we could get a PeerMessage or a ViewUpdate.
ViewUpdate tells us about latest blocks (heads) and finalized number with our peers.
We are supposed to be update our peer data with these views.
This PR, reads ViewUpdate from both collation and validation protocol and handles them inside network bridge by updating our peer data. Later, it sends that view to other subsystems so that each subsystem can update their view too.
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
Fixes #3864