feat(grandpa): implement neighbor tracker and message handling #4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimjbrettj
requested review from
EclesioMeloJunior,
timwu20 and
kishansagathiya
as code owners
jimjbrettj
force-pushed
the
jimmy/neighborMsgTracking
branch
from
6293cf3
to
0c0cbb8
Compare
jimjbrettj
changed the base branch from
jimmy/paseoBlock1789153
to
development
jimjbrettj
force-pushed
the
jimmy/neighborMsgTracking
branch
from
b51687a
to
7c17435
Compare
EclesioMeloJunior
approved these changes
Oct 8, 2024
jimjbrettj
force-pushed
the
jimmy/neighborMsgTracking
branch
from
7c17435
to
38ae1e9
Compare
haikoschol
approved these changes
Oct 15, 2024
haikoschol
reviewed
Oct 15, 2024
haikoschol
approved these changes
Oct 15, 2024
jimjbrettj
force-pushed
the
jimmy/neighborMsgTracking
branch
from
370e30c
to
8104f27
Compare
timwu20
requested changes
Oct 16, 2024
jimjbrettj
force-pushed
the
jimmy/neighborMsgTracking
branch
from
8104f27
to
9aee52b
Compare
|
@timwu20 Responded to feedback, fixed broken integration tests, and added tests for 1) start/stop 2) updating peer state via channel. I did not add testing for the finalization channel because no state is actually updated based on it so I didnt know what to assert. Since this channel is used/tested in other parts of the code I thought this is okay, but let me know if/how this should be updated. |
timwu20
reviewed
Oct 28, 2024
jimjbrettj
force-pushed
the
jimmy/neighborMsgTracking
branch
from
4f39d8f
to
fa4d931
Compare
timwu20
reviewed
Oct 30, 2024
timwu20
reviewed
Oct 30, 2024
timwu20
approved these changes
Oct 30, 2024
jimjbrettj
force-pushed
the
jimmy/neighborMsgTracking
branch
from
fa4d931
to
6625430
Compare
jimjbrettj
force-pushed
the
jimmy/neighborMsgTracking
branch
from
6625430
to
3dbb1db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the neighbor messaging protocol. This includes the ability to handle received neighbor messages, the ability to correctly send neighbor messages, as well as tracking the state of our neighbors (that we use when deciding who to send messages too),
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
#2931