fix: storage root mismatch at block 1789153 #4189
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimjbrettj
changed the base branch from
development
to
eclesio/sync-strategy
| @@ -832,6 +832,7 @@ func ext_trie_blake2_256_root_version_2(ctx context.Context, m api.Module, dataS | |||
| } | |||
|
|
|||
| func ext_trie_blake2_256_ordered_root_version_1(ctx context.Context, m api.Module, dataSpan uint64) uint32 { | |||
| // Why is this hardcoded to 0?? | |||
There was a problem hiding this comment.
we hard code to 0 because the routine to get the blake2_256 hash for the trie is the same but only the version changes, so we use version 0 as default for ext_trie_blake2_256_ordered_root_version_1, the runtime still using this host function for extrinsic root state hash
jimjbrettj
force-pushed
the
jimmy/paseoBlock1789153
branch
from
39f7849
to
74d7433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
#4182