feat(dot/network): Add warp sync request handler #4186
Conversation
dimartiro
force-pushed
the
diego/warp-sync-req_handler
branch
from
99bf75a
to
a7e03f7
Compare
dimartiro
changed the base branch from
eclesio/sync-strategy
to
development
dimartiro
force-pushed
the
diego/warp-sync-req_handler
branch
from
0e840fc
to
592876a
Compare
dimartiro
requested review from
EclesioMeloJunior,
jimjbrettj,
timwu20 and
kishansagathiya
as code owners
| @@ -66,6 +66,7 @@ type Config struct { | |||
| // Service interfaces | |||
| BlockState BlockState | |||
| Syncer Syncer | |||
| warpSyncProvider WarpSyncProvider | |||
There was a problem hiding this comment.
This will probably need to be public right?
| } | ||
|
|
||
| // Decode decodes the message into a WarpProofRequest | ||
| func (wsr *WarpProofRequest) Decode(in []byte) error { |
There was a problem hiding this comment.
| func (wsr *WarpProofRequest) Decode(in []byte) error { | |
| func (wpr *WarpProofRequest) Decode(in []byte) error { |
same for below receivers
| // Encode encodes the warp sync request | ||
| func (wsr *WarpProofRequest) Encode() ([]byte, error) { | ||
| buffer := bytes.NewBuffer(nil) | ||
| encoder := scale.NewEncoder(buffer) |
There was a problem hiding this comment.
For both encoding and decoding here, do we need to create the encoder/decoder object? Can we not just call scale.Marshal and scale.Unmarshal?
| stream.Conn().RemotePeer(), | ||
| resp, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Should we add a log or something for the !ok case?
|
|
||
| // Test encoding | ||
| reqEnc, err := testWarpReqMessage.Encode() | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Are there any tests in substrate with hardcoded bytes that we could use here? We have run into a problem before in serialization tests where we can encode and decode to an expected type, but the actual byte representation is incorrect.
However giving how simple this is, probably is not the end of the world. I just wanted to make a note of this
Changes
Adds warp sync request handler.
/sync/warpThis implementation is slightly different from the one proposed in #4052, but I think it's more straightforward and less complex, which will help us achieve a quick warp sync implementation. We can discuss or revisit this later.
Tests
go test ./dot/networkIssues
closing: #4052