Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(dot/parachain/backing): ensure conflicting statments treated as misbehavior #4164

Merged
merged 3 commits into from
Sep 17, 2024
Merged

test(dot/parachain/backing): ensure conflicting statments treated as misbehavior #4164

merged 3 commits into from
Sep 17, 2024

Conversation

axaysagathiya
Copy link
Contributor

Changes

  • I have written the test to ensure conflicting statements issued by a validator on the same candidate are treated as misbehaviour.
    • sent statement message with Seconded validity statement from overseer to candidate backing.
    • sent another message with a Valid validity statement for the same candidate from overseer to candidate backing. But as we have already seconded the statement, it is a misbehaviour.
  • Added the method to verify the signature for the issued validity statement.

Tests

go test ./dot/parachain/... -v -timeout 1m

Issues

Closes #4006

@axaysagathiya axaysagathiya self-assigned this Sep 7, 2024
edwardmack
edwardmack approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@edwardmack edwardmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

dot/parachain/backing/integration_test.go Outdated Show resolved Hide resolved
dot/parachain/types/statement.go Outdated Show resolved Hide resolved
@axaysagathiya axaysagathiya merged commit a37a18a into feat/parachain Sep 17, 2024
22 checks passed
@axaysagathiya axaysagathiya deleted the axay/test/backing/conflicting-statement-is-misbehavior branch September 17, 2024 06:04
edwardmack added a commit that referenced this pull request Oct 4, 2024
@edwardmack
add addition validation timeout tests
67b3274 
address PR comments

address PR comments, rename variables and functions

fix test

remove printf from debugging

address PR comments

test(dot/parachain/backing): ensure conflicting statments treated as misbehavior (#4164)

fix merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@edwardmack edwardmack edwardmack approved these changes

@timwu20 timwu20 timwu20 approved these changes

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya kishansagathiya is a code owner

Assignees

@axaysagathiya axaysagathiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axaysagathiya @timwu20 @edwardmack @EclesioMeloJunior