feat(dot/parachain): Confirm invalidity errors are implemented in candidate validation. #4163
+372
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardmack
force-pushed
the
ed/feat/candidate_validation_confirm_errors
branch
from
d19c27e
to
cdc3514
Compare
edwardmack
requested review from
EclesioMeloJunior,
jimjbrettj,
timwu20 and
kishansagathiya
as code owners
edwardmack
changed the title
timwu20
reviewed
Sep 16, 2024
| mockValidationInstance := NewMockValidatorInstance(ctrl) | ||
| mockValidationInstance.EXPECT().ValidateBlock(gomock.Any()).DoAndReturn(func(parachain. | ||
| ValidationParameters) (*parachain.ValidationResult, error) { | ||
| time.Sleep(3 * time.Second) // sleep to simulate execution time |
There was a problem hiding this comment.
does it really need to be this long?
There was a problem hiding this comment.
This is 3 seconds since the default timeout period is 2 seconds.
…t/candidate_validation_confirm_errors
Base automatically changed from
ed/feat/candidate_validation_pvf_host_base
to
feat/parachain
September 19, 2024 13:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Polkadot has an defined an enum (https://github.com/paritytech/polkadot/blob/153543b0c8c582e73f520e5c08cbe33bddfb5f69/node/primitives/src/lib.rs#L229) to represent the types of candidate invalidity that can happen during candidate validation.
This PR:
Tests
go test github.com/ChainSafe/gossamer/dot/parachain/candidate-validationIssues
closes issue #3426
Primary Reviewer
@axaysagathiya @kishansagathiya @timwu20