Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib/runtime): Remove duplicate keys from storageDiff.clearPrefix #4147

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

jimjbrettj
Copy link
Contributor

Changes

  • Only append keys that are not already in the set

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

#4141

@jimjbrettj jimjbrettj added T-bug this issue covers unexpected and/or wrong behaviour. C-simple Minor changes changes, no additional research needed. Good first issue/review. labels Aug 26, 2024
@timwu20 timwu20 changed the title fix(runtime): Remove duplicate keys from storageDiff.clearPrefix fix(lib/runtime): Remove duplicate keys from storageDiff.clearPrefix Sep 10, 2024
@jimjbrettj jimjbrettj force-pushed the jimmy/removeDuplicatesFromClearPrefix branch from cbc1b81 to b8494f1 Compare September 11, 2024 12:16
@jimjbrettj jimjbrettj merged commit 313f960 into development Sep 11, 2024
22 of 24 checks passed
@jimjbrettj jimjbrettj deleted the jimmy/removeDuplicatesFromClearPrefix branch September 11, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-simple Minor changes changes, no additional research needed. Good first issue/review. T-bug this issue covers unexpected and/or wrong behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants