Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lib/sync): introduce fullsync strategy #4114

Merged
merged 92 commits into from
Sep 30, 2024
Merged

refactor(lib/sync): introduce fullsync strategy #4114

merged 92 commits into from
Sep 30, 2024

Conversation

EclesioMeloJunior
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior commented Aug 6, 2024 •
edited
Loading

Changes

  • Remove dot/sync package
  • New sync package at lib/sync
  • Remove the concept of bootstrap and tip sync and just uses the fullsync as the default strategy
  • The SyncService uses the strategy approach as described in Refactor sync package to use the strategy approach #4112
  • This PR contains does not contains the concurrent request method process

Tests

go test -timeout 10m github.com/ChainSafe/gossamer/lib/sync --tags=integration -v

Issues

jimjbrettj
jimjbrettj reviewed Aug 12, 2024
View reviewed changes
dot/services.go Outdated Show resolved Hide resolved
jimjbrettj
jimjbrettj reviewed Aug 12, 2024
View reviewed changes
dot/services.go Outdated Show resolved Hide resolved
jimjbrettj
jimjbrettj reviewed Aug 12, 2024
View reviewed changes
dot/services.go Outdated Show resolved Hide resolved
jimjbrettj
jimjbrettj reviewed Aug 12, 2024
View reviewed changes
lib/sync/fullsync.go Outdated Show resolved Hide resolved
timwu20
timwu20 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@timwu20 timwu20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments. Great work @EclesioMeloJunior!

dot/sync/fullsync_handle_block.go Outdated Show resolved Hide resolved
dot/sync/fullsync.go Outdated Show resolved Hide resolved
dot/sync/fullsync.go Outdated Show resolved Hide resolved
dot/sync/fullsync_handle_block.go Outdated Show resolved Hide resolved
@EclesioMeloJunior EclesioMeloJunior enabled auto-merge (squash) September 30, 2024 11:18
jimjbrettj
jimjbrettj reviewed Sep 30, 2024
View reviewed changes
dot/network/host.go Outdated Show resolved Hide resolved
jimjbrettj
jimjbrettj approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave another look over, looks great! Few minor comments but you can use your discretion if you want to accept them or not.

@EclesioMeloJunior EclesioMeloJunior merged commit dbe6858 into development Sep 30, 2024
23 of 24 checks passed
@EclesioMeloJunior EclesioMeloJunior deleted the eclesio/sync-strategy branch September 30, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimjbrettj jimjbrettj jimjbrettj approved these changes

@P1sar P1sar P1sar approved these changes

@edwardmack edwardmack edwardmack approved these changes

@timwu20 timwu20 timwu20 approved these changes

@haikoschol haikoschol haikoschol approved these changes

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya kishansagathiya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gossamer sync target is not being correctly updated Refactor sync package to use the strategy approach
6 participants
@EclesioMeloJunior @P1sar @timwu20 @haikoschol @edwardmack @jimjbrettj