Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1sar/feat/system dry run rpc #4042

Draft
wants to merge 2 commits into
base: development
Choose a base branch
from
Draft

P1sar/feat/system dry run rpc #4042

wants to merge 2 commits into from

Conversation

P1sar
Copy link
Member

@P1sar P1sar commented Jun 14, 2024

Changes

Added system_dryRun RPC method.
Specification listed here and here

Currently PR is in Draft version for visibility.
Work i still in progress, next parts needs to be completed:

  • Test are not passing correctly
  • Implement one more test
  • Specific runtime execution for runtime version <6

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

#1721

@P1sar P1sar added C-simple Minor changes changes, no additional research needed. Good first issue/review. S-rpc issues related to the dot/rpc package. labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior EclesioMeloJunior will be requested when the pull request is marked ready for review EclesioMeloJunior is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj will be requested when the pull request is marked ready for review jimjbrettj is a code owner

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 will be requested when the pull request is marked ready for review timwu20 is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya kishansagathiya will be requested when the pull request is marked ready for review kishansagathiya is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
C-simple Minor changes changes, no additional research needed. Good first issue/review. S-rpc issues related to the dot/rpc package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@P1sar