-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pkg/trie): Encapsulate in-memory trie impl in its own package #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimartiro
changed the title
Diego/trie inmemory package
refactor(pkg/trie): Encapsulate in-memory trie impl in its own package
Mar 21, 2024
…into diego/trie-inmemory-package
dimartiro
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
axaysagathiya
as code owners
March 27, 2024 18:19
jimjbrettj
reviewed
Mar 27, 2024
jimjbrettj
reviewed
Mar 27, 2024
Co-authored-by: JimboJ <[email protected]>
jimjbrettj
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…o/trie-inmemory-package
EclesioMeloJunior
approved these changes
Mar 27, 2024
timwu20
pushed a commit
that referenced
this pull request
Apr 19, 2024
#3803) Co-authored-by: JimboJ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is to create an independent
inmemory
package withinpkg/trie
to encapsulate theInmemoryTrie
implementation there.This is useful to prevent mixing the new code for the lazy loading trie implementation (aka: TrieDB) with the old inmemory trie implementation
Summary of changes
/pkg/trie/inmemory
folderinmemory_trie
as alias instead of using oldtrie
packagelayout_test
as part of/pkg/trie/inmemory
to test the layout for the in-memory trie implementation/pkg/trie/proof
to/pkg/trie/inmemory/proof
since it's coupled with the trie implementationTrie
parameter tolayout.Root
function to make it generic based onTrie
implementationTests
make test
Issues
closes #3804
Primary Reviewer
@jimjbrettj