Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wazero fork upgrade to use uint64 for memory.Size() #3800

Merged
merged 12 commits into from
Mar 22, 2024
Merged

feat: wazero fork upgrade to use uint64 for memory.Size() #3800

merged 12 commits into from
Mar 22, 2024

Conversation

EclesioMeloJunior
Copy link
Member

Changes

  • Upgrading the Chainsafe/wazero fork dep to use correctly the uint64 size type
  • Clean up the allocator after the full block execution

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Primary Reviewer

@

@EclesioMeloJunior EclesioMeloJunior mentioned this pull request Mar 18, 2024
Closed
1 task
jimjbrettj
jimjbrettj approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dimartiro
dimartiro approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@dimartiro dimartiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

timwu20
timwu20 reviewed Mar 20, 2024
View reviewed changes
lib/runtime/allocator/freeing_bump.go Outdated Show resolved Hide resolved
lib/runtime/wazero/instance.go Outdated Show resolved Hide resolved
@EclesioMeloJunior EclesioMeloJunior merged commit 5629c17 into development Mar 22, 2024
24 checks passed
@EclesioMeloJunior EclesioMeloJunior deleted the eclesio/wazero-fork-upgrade branch March 22, 2024 13:48
timwu20 pushed a commit that referenced this pull request Apr 19, 2024
@EclesioMeloJunior @timwu20
feat: wazero fork upgrade to use uint64 for memory.Size() (#3800)
9ef1fab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimartiro dimartiro dimartiro approved these changes

@timwu20 timwu20 timwu20 approved these changes

@jimjbrettj jimjbrettj jimjbrettj approved these changes

@edwardmack edwardmack Awaiting requested review from edwardmack

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya kishansagathiya is a code owner

@axaysagathiya axaysagathiya Awaiting requested review from axaysagathiya

@P1sar P1sar Awaiting requested review from P1sar P1sar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(lib/runtime): fail to execute block 17088245 allocator out of space
5 participants
@EclesioMeloJunior @dimartiro @timwu20 @P1sar @jimjbrettj