fix(lib/blocktree): improve blocktree.GetHashesAtNumber
#3799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EclesioMeloJunior
requested review from
edwardmack,
timwu20,
jimjbrettj,
kishansagathiya,
dimartiro and
axaysagathiya
as code owners
EclesioMeloJunior
added
S-state
jimjbrettj
reviewed
Mar 14, 2024
jimjbrettj
reviewed
Mar 14, 2024
jimjbrettj
approved these changes
Mar 14, 2024
timwu20
requested changes
Mar 20, 2024
timwu20
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Change the name from
GetBlocksAtNumbertoGetHashesAtNumbergiven the fact that this function returns a slice of hashes and not a slice of blocksImprove the function to run based on the actual number and not based on the parent hash of the desired number?
The function first try to search the slice of hashes with the same number in the in-memory block tree first if results are found then we return the hashes, if nothing returns then try to retrieve the hash from database (we map the number -> hash in the db)
These changes are needed to complete issue BABE: added reusing last epoch data in case of skipped epochs #3430. Gossamer should be aware of the very first slot number (slot number for the first non genesis block) and might exist a case where more than 1 block is the first non genesis block, then we should use
GetHashesAtNumberto check if there is more than one block#1and in this case use the correct first slotTests
Issues
Primary Reviewer
@