Merge branch 'feat/parachain' into feat/kishan/collation-protocol-pee…

…r-view-change
ChainSafe · Nov 5, 2024 · d362070 · d362070
2 parents 63950af + e030fa7
commit d362070
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/dot/parachain/collator-protocol/validator_side.go b/dot/parachain/collator-protocol/validator_side.go
@@ -85,7 +85,7 @@ func (cpvs CollatorProtocolValidatorSide) Run(
 			}
 
 		case <-inactivityTicker.C:
-			// TODO: disconnect inactive peers
+			// TODO: disconnect inactive peers, Issue #4256
 			// https://github.com/paritytech/polkadot/blob/8f05479e4bd61341af69f0721e617f01cbad8bb2/node/network/collator-protocol/src/validator_side/mod.rs#L1301
 
 		case unfetchedCollation := <-cpvs.unfetchedCollation:
@@ -161,7 +161,7 @@ func (cpvs *CollatorProtocolValidatorSide) handleOurViewChange(view parachaintyp
 
 		//nolint:staticcheck
 		if mode.IsEnabled {
-			// TODO: Add it when we have async backing
+			// TODO: Add it when we have async backing, Issue #4253
 			// https://github.com/paritytech/polkadot-sdk/blob/aa68ea58f389c2aa4eefab4bf7bc7b787dd56580/polkadot/node/network/collator-protocol/src/validator_side/mod.rs#L1303 //nolint
 		}
 	}
@@ -173,7 +173,7 @@ func (cpvs *CollatorProtocolValidatorSide) handleOurViewChange(view parachaintyp
 		mode := prospectiveParachainMode()
 		pruned := []common.Hash{}
 		if mode.IsEnabled {
-			// TODO: Do this when we have async backing
+			// TODO: Do this when we have async backing,  Issue #4253
 			// https://github.com/paritytech/polkadot-sdk/blob/aa68ea58f389c2aa4eefab4bf7bc7b787dd56580/polkadot/node/network/collator-protocol/src/validator_side/mod.rs#L1340 //nolint
 		} else {
 			pruned = append(pruned, leaf)
@@ -317,7 +317,7 @@ func signingKeyAndIndex(validators []parachaintypes.ValidatorID, ks keystore.Key
 }
 
 func prospectiveParachainMode() parachaintypes.ProspectiveParachainsMode {
-	// TODO: complete this method by calling the runtime function
+	// TODO: complete this method by calling the runtime function Issue #4254
 	// https://github.com/paritytech/polkadot-sdk/blob/aa68ea58f389c2aa4eefab4bf7bc7b787dd56580/polkadot/node/subsystem-util/src/runtime/mod.rs#L496 //nolint
 	// NOTE: We will return false until we have support for async backing
 	return parachaintypes.ProspectiveParachainsMode{
@@ -844,7 +844,7 @@ func (cpvs CollatorProtocolValidatorSide) processMessage(msg any) error {
 				cpvs.perRelayParent[msg.Parent] = perRelayParent
 			}
 
-			// TODO: Few more things for async backing, but we don't have async backing yet
+			// TODO: Few more things for async backing, but we don't have async backing yet Issue #4255
 			// https://github.com/paritytech/polkadot-sdk/blob/7035034710ecb9c6a786284e5f771364c520598d/polkadot/node/network/collator-protocol/src/validator_side/mod.rs#L1531-L1532
 		}
 	case collatorprotocolmessages.Backed: