Fix deepsource checks

ChainSafe · Aug 10, 2023 · b816195 · b816195
1 parent 3293693
commit b816195
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/dot/state/storage_notify_test.go b/dot/state/storage_notify_test.go
@@ -182,13 +182,11 @@ func Test_Example(t *testing.T) {
 
 	// Write both keys, but only one should be printed in the Output.
 	err := db.Put(aKey, aValue)
-	if err != nil {
-		log.Fatal(err)
-	}
+	require.NoError(t, err)
+
 	err = db.Put(bKey, bValue)
-	if err != nil {
-		log.Fatal(err)
-	}
+	require.NoError(t, err)
+
 	log.Printf("stopping subscription")
 	cancel()
 	log.Printf("waiting for subscription to close")

diff --git a/dot/state/storage_test.go b/dot/state/storage_test.go
@@ -45,8 +45,8 @@ func TestStorage_StoreAndLoadTrie(t *testing.T) {
 	trie, err := storage.LoadFromDB(root)
 	require.NoError(t, err)
 	ts2 := runtime.NewTrieState(trie)
-	new := ts2.Snapshot()
-	require.Equal(t, ts.Trie(), new)
+	newTrie := ts2.Snapshot()
+	require.Equal(t, ts.Trie(), newTrie)
 }
 
 func TestStorage_GetStorageByBlockHash(t *testing.T) {

diff --git a/dot/state/test_helpers.go b/dot/state/test_helpers.go
@@ -153,7 +153,7 @@ func AddBlocksToState(t *testing.T, blockState *BlockState, depth uint,
 // branches are provided with a map of depth -> # of branches
 func AddBlocksToStateWithFixedBranches(t *testing.T, blockState *BlockState, depth uint, branches map[uint]int) {
 	bestBlockHash := blockState.BestBlockHash()
-	tb := []testBranch{}
+	var tb []testBranch
 	arrivalTime := time.Now()
 
 	rt, err := blockState.GetRuntime(bestBlockHash)