fixing more tests

ChainSafe · Sep 18, 2024 · ae2bad6 · ae2bad6
1 parent bb661d7
commit ae2bad6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/dot/parachain/collator-protocol/validator_side_test.go b/dot/parachain/collator-protocol/validator_side_test.go
@@ -436,6 +436,7 @@ func TestProcessBackedOverseerMessage(t *testing.T) {
 			ctrl := gomock.NewController(t)
 			defer ctrl.Finish()
 			overseer := overseer.NewMockableOverseer(t)
+			overseer.ExpectActions(c.expectedActions...)
 
 			collationProtocolID := "/6761727661676500000000000000000000000000000000000000000000000000/1/collations/1"
 
@@ -453,9 +454,6 @@ func TestProcessBackedOverseerMessage(t *testing.T) {
 
 			defer overseer.Stop()
 
-			// overseer.ReceiveMessage(c.msg)
-			overseer.ExpectActions(c.expectedActions...)
-
 			time.Sleep(1 * time.Second)
 			lenBlackedAdvertisementsBefore := len(cpvs.BlockedAdvertisements)
 

diff --git a/dot/parachain/overseer/mockable_overseer.go b/dot/parachain/overseer/mockable_overseer.go
@@ -100,15 +100,6 @@ func (m *MockableOverseer) processMessages() {
 				m.t.Errorf("unexpected message: %T", msg)
 				return
 			}
-		case <-m.ctx.Done():
-			if actionIndex < len(m.actionsForExpectedMessages) {
-				m.t.Errorf("expected %d overseer actions, but got only %d", len(m.actionsForExpectedMessages), actionIndex)
-			}
-
-			if err := m.ctx.Err(); err != nil {
-				m.t.Logf("ctx error: %v\n", err)
-			}
-			return
 		}
 	}
 }