chore(release): release v0.5.0 (#1562)

.github/CODEOWNERS

@@ -1,4 +1,4 @@
 # CODEOWNERS: https://help.github.com/articles/about-codeowners/
 
 # Primary repo maintainers
-*       @noot @arijitAD @edwardmack
+*       @noot @arijitAD @edwardmack @timwu20

.github/CODE_OF_CONDUCT.md

@@ -11,7 +11,7 @@ appearance, race, religion, or sexual identity and orientation.
 
 ## Our Standards
 
-Examples of behavior that contributes to creating a positive environment
+Examples of behaviour that contributes to creating a positive environment
 include:
 
 * Using welcoming and inclusive language
@@ -20,7 +20,7 @@ include:
 * Focusing on what is best for the community
 * Showing empathy towards other community members
 
-Examples of unacceptable behavior by participants include:
+Examples of unacceptable behaviour by participants include:
 
 * The use of sexualized language or imagery and unwelcome sexual attention or
  advances
@@ -34,13 +34,13 @@ Examples of unacceptable behavior by participants include:
 ## Our Responsibilities
 
 Project maintainers are responsible for clarifying the standards of acceptable
-behavior and are expected to take appropriate and fair corrective action in
-response to any instances of unacceptable behavior.
+behaviour and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behaviour.
 
 Project maintainers have the right and responsibility to remove, edit, or
 reject comments, commits, code, wiki edits, issues, and other contributions
 that are not aligned to this Code of Conduct, or to ban temporarily or
-permanently any contributor for other behaviors that they deem inappropriate,
+permanently any contributor for other behaviours that they deem inappropriate,
 threatening, offensive, or harmful.
 
 ## Scope

.github/CONTRIBUTING.md

@@ -44,7 +44,7 @@ $ git remote -v (you should see myrepo and gossamer in the list of remotes)
 
 To start, check out our open issues. We recommend starting with an [issue labeled `Good First Issue`](https://github.com/ChainSafe/gossamer/issues?q=is%3Aopen+is%3Aissue+label%3A%22Good+First+Issue%22). Leave a comment to let us know that you would like to work on it. 
 
-Another option is to improve gossamer where you see fit based on your evaluation of our code. In order to best faciliate collaboration, please create an issue before you start working on it.
+Another option is to improve gossamer where you see fit based on your evaluation of our code. In order to best facilitate collaboration, please create an issue before you start working on it.
 
 **6. Make improvements to the code.**
 
@@ -76,7 +76,7 @@ Navigate your browser to [https://github.com/ChainSafe/gossamer](https://github.
 
 ## Note on memory intensive tests
 Unfortunately, the free tier for CI's have a memory cap and some tests will cause the CI to experience an out of memory error.
-In order to mitigate this we have introduced the concept of **short tests**. If your PR causes an out of memory error please seperate the tests into two groups
+In order to mitigate this we have introduced the concept of **short tests**. If your PR causes an out of memory error please separate the tests into two groups
 like below and make sure to label it `large`:
 
 ```

.github/ISSUE_TEMPLATE/bug_report.md

@@ -30,10 +30,10 @@ If you're suggesting a change/improvement, tell us how it should work.
 
 <!---
 
-If describing a bug, tell us what happens instead of the expected behavior.
+If describing a bug, tell us what happens instead of the expected behaviour.
 
 If suggesting a change or an improvement, explain the difference between your
-suggestion and current behavior.
+suggestion and current behaviour.
 
 -->
 
@@ -55,7 +55,7 @@ submit a PR and you'll get credit for the whole thing.
 
 
 ## To Reproduce
-Steps to reproduce the behavior:
+Steps to reproduce the behaviour:
 
 1. 
 2. 

.github/workflows/release.yml

@@ -1,7 +1,7 @@
 name: Release
 on:
   push:
-    branches: [main, development]
+    branches: [main]
 
 jobs:
   release:
@@ -23,4 +23,4 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
-        run: npx semantic-release
+        run: npx semantic-release

.github/workflows/tests.yml

@@ -58,8 +58,7 @@ jobs:
           run: |
             go test ./... -short -coverprofile=coverage.out -covermode=atomic -timeout=20m
         - uses: codecov/codecov-action@v1
-          with:
-            token: "89982880-a53b-4a3a-9bdd-3dc9c78bd190"
+          with:      
             files: ./coverage.out
             flags: unit-tests
             name: coverage

.golangci.yml

@@ -41,7 +41,7 @@ run:
 
   # which files to skip: they will be analyzed, but issues from them
   # won't be reported. Default value is empty list, but there is
-  # no need to include all autogenerated files, we confidently recognize
+  # no need to include all autogenerated files, we confidently recognise
   # autogenerated files. If it's not please let us know.
   #skip-files:
 
@@ -132,7 +132,7 @@ linters-settings:
     # Correct spellings using locale preferences for US or UK.
     # Default is to use a neutral variety of English.
     # Setting locale to US will correct the British spelling of 'colour' to 'color'.
-    locale: US
+    locale: UK
     ignore-words:
       - gossamer
   lll:

Makefile

@@ -87,7 +87,7 @@ build-debug:
 	@echo "  >  \033[32mBuilding binary...\033[0m "
 	GOBIN=$(PWD)/bin go run scripts/ci.go install-debug
 
-## init: Initialize gossamer using the default genesis and toml configuration files
+## init: Initialise gossamer using the default genesis and toml configuration files
 init:
 	./bin/gossamer --key alice init --genesis chain/gssmr/genesis.json --force
 

README.md

@@ -60,7 +60,7 @@ make gossamer
 
 ### Run Default Node
 
-initialize default node:
+initialise default node:
 ```
 ./bin/gossamer --chain gssmr init
 ```
@@ -87,7 +87,7 @@ Then, re-run the above steps. NOTE: this feature is for testing only; if you wis
 
 ### Run Kusama Node
 
-initialize kusama node:
+initialise kusama node:
 ```
 ./bin/gossamer --chain kusama init
 ```
@@ -108,7 +108,7 @@ After it's finished bootstrapping, the node should begin to sync.
 
 ### Run Polkadot Node
 
-initialize polkadot node:
+initialise polkadot node:
 ```
 ./bin/gossamer --chain polkadot init
 ```

cmd/gossamer/config.go

@@ -17,7 +17,6 @@
 package main
 
 import (
-	"encoding/binary"
 	"fmt"
 	"strconv"
 	"strings"
@@ -33,7 +32,7 @@ import (
 	"github.com/ChainSafe/gossamer/lib/runtime/life"
 	"github.com/ChainSafe/gossamer/lib/runtime/wasmer"
 	"github.com/ChainSafe/gossamer/lib/runtime/wasmtime"
-	"github.com/cosmos/go-bip39"
+	"github.com/ChainSafe/gossamer/lib/utils"
 
 	log "github.com/ChainSafe/log15"
 	"github.com/urfave/cli"
@@ -132,7 +131,10 @@ func createDotConfig(ctx *cli.Context) (*dot.Config, error) {
 	logger.Info("loaded package log configuration", "cfg", cfg.Log)
 
 	// set global configuration values
-	setDotGlobalConfig(ctx, tomlCfg, &cfg.Global)
+	if err := setDotGlobalConfig(ctx, tomlCfg, &cfg.Global); err != nil {
+		logger.Error("failed to set global node configuration", "error", err)
+		return nil, err
+	}
 
 	// set remaining cli configuration values
 	setDotInitConfig(ctx, tomlCfg.Init, &cfg.Init)
@@ -151,7 +153,7 @@ func createDotConfig(ctx *cli.Context) (*dot.Config, error) {
 	return cfg, nil
 }
 
-// createInitConfig creates the configuration required to initialize a dot node
+// createInitConfig creates the configuration required to initialise a dot node
 func createInitConfig(ctx *cli.Context) (*dot.Config, error) {
 	tomlCfg, cfg, err := setupConfigFromChain(ctx)
 	if err != nil {
@@ -160,7 +162,11 @@ func createInitConfig(ctx *cli.Context) (*dot.Config, error) {
 	}
 
 	// set global configuration values
-	setDotGlobalConfig(ctx, tomlCfg, &cfg.Global)
+	err = setDotGlobalConfig(ctx, tomlCfg, &cfg.Global)
+	if err != nil {
+		logger.Error("failed to set global node configuration", "error", err)
+		return nil, err
+	}
 
 	// set log config
 	err = setLogConfig(ctx, tomlCfg, &cfg.Global, &cfg.Log)
@@ -196,7 +202,11 @@ func createImportStateConfig(ctx *cli.Context) (*dot.Config, error) {
 	}
 
 	// set global configuration values
-	setDotGlobalConfig(ctx, tomlCfg, &cfg.Global)
+	if err := setDotGlobalConfig(ctx, tomlCfg, &cfg.Global); err != nil {
+		logger.Error("failed to set global node configuration", "error", err)
+		return nil, err
+	}
+
 	return cfg, nil
 }
 
@@ -210,7 +220,11 @@ func createBuildSpecConfig(ctx *cli.Context) (*dot.Config, error) {
 	}
 
 	// set global configuration values
-	setDotGlobalConfig(ctx, tomlCfg, &cfg.Global)
+	if err := setDotGlobalConfig(ctx, tomlCfg, &cfg.Global); err != nil {
+		logger.Error("failed to set global node configuration", "error", err)
+		return nil, err
+	}
+
 	return cfg, nil
 }
 
@@ -229,7 +243,11 @@ func createExportConfig(ctx *cli.Context) (*dot.Config, error) {
 	updateDotConfigFromGenesisJSONRaw(*tomlCfg, cfg)
 
 	// set global configuration values
-	setDotGlobalConfig(ctx, tomlCfg, &cfg.Global)
+	err = setDotGlobalConfig(ctx, tomlCfg, &cfg.Global)
+	if err != nil {
+		logger.Error("failed to set global node configuration", "error", err)
+		return nil, err
+	}
 
 	// set log config
 	err = setLogConfig(ctx, &ctoml.Config{}, &cfg.Global, &cfg.Log)
@@ -385,13 +403,27 @@ func setDotInitConfig(ctx *cli.Context, tomlCfg ctoml.InitConfig, cfg *dot.InitC
 	)
 }
 
-// setDotGlobalConfig sets dot.GlobalConfig using flag values from the cli context
-func setDotGlobalConfig(ctx *cli.Context, tomlCfg *ctoml.Config, cfg *dot.GlobalConfig) {
-	if tomlCfg != nil {
-		if tomlCfg.Global.Name != "" {
-			cfg.Name = tomlCfg.Global.Name
-		}
+func setDotGlobalConfig(ctx *cli.Context, tomlConfig *ctoml.Config, cfg *dot.GlobalConfig) error {
+	setDotGlobalConfigFromToml(tomlConfig, cfg)
+	setDotGlobalConfigFromFlags(ctx, cfg)
+
+	if err := setDotGlobalConfigName(ctx, tomlConfig, cfg); err != nil {
+		return fmt.Errorf("could not set global node name: %w", err)
+	}
 
+	logger.Debug(
+		"global configuration",
+		"name", cfg.Name,
+		"id", cfg.ID,
+		"basepath", cfg.BasePath,
+	)
+
+	return nil
+}
+
+// setDotGlobalConfigFromToml will apply the toml configs to dot global config
+func setDotGlobalConfigFromToml(tomlCfg *ctoml.Config, cfg *dot.GlobalConfig) {
+	if tomlCfg != nil {
 		if tomlCfg.Global.ID != "" {
 			cfg.ID = tomlCfg.Global.ID
 		}
@@ -406,20 +438,10 @@ func setDotGlobalConfig(ctx *cli.Context, tomlCfg *ctoml.Config, cfg *dot.Global
 
 		cfg.MetricsPort = tomlCfg.Global.MetricsPort
 	}
+}
 
-	// TODO: generate random name if one is not assigned (see issue #1496)
-	// check --name flag and update node configuration
-	if name := ctx.GlobalString(NameFlag.Name); name != "" {
-		cfg.Name = name
-	} else {
-		// generate random name
-		entropy, _ := bip39.NewEntropy(128)
-		randomNamesString, _ := bip39.NewMnemonic(entropy)
-		randomNames := strings.Split(randomNamesString, " ")
-		number := binary.BigEndian.Uint16(entropy)
-		cfg.Name = randomNames[0] + "-" + randomNames[1] + "-" + fmt.Sprint(number)
-	}
-
+// setDotGlobalConfigFromFlags sets dot.GlobalConfig using flag values from the cli context
+func setDotGlobalConfigFromFlags(ctx *cli.Context, cfg *dot.GlobalConfig) {
 	// check --basepath flag and update node configuration
 	if basepath := ctx.GlobalString(BasePathFlag.Name); basepath != "" {
 		cfg.BasePath = basepath
@@ -429,6 +451,7 @@ func setDotGlobalConfig(ctx *cli.Context, tomlCfg *ctoml.Config, cfg *dot.Global
 	if cfg.BasePath == "" {
 		cfg.BasePath = dot.GssmrConfig().Global.BasePath
 	}
+
 	// check --log flag
 	if lvlToInt, err := strconv.Atoi(ctx.String(LogFlag.Name)); err == nil {
 		cfg.LogLvl = log.Lvl(lvlToInt)
@@ -444,13 +467,39 @@ func setDotGlobalConfig(ctx *cli.Context, tomlCfg *ctoml.Config, cfg *dot.Global
 	}
 
 	cfg.NoTelemetry = ctx.Bool("no-telemetry")
+}
 
-	logger.Debug(
-		"global configuration",
-		"name", cfg.Name,
-		"id", cfg.ID,
-		"basepath", cfg.BasePath,
-	)
+func setDotGlobalConfigName(ctx *cli.Context, tomlCfg *ctoml.Config, cfg *dot.GlobalConfig) error {
+	globalBasePath := utils.ExpandDir(cfg.BasePath)
+	initialised := dot.NodeInitialized(globalBasePath, false)
+
+	// consider the --name flag as higher priority
+	if ctx.GlobalString(NameFlag.Name) != "" {
+		cfg.Name = ctx.GlobalString(NameFlag.Name)
+		return nil
+	}
+
+	// consider the name on config as a second priority
+	if tomlCfg.Global.Name != "" {
+		cfg.Name = tomlCfg.Global.Name
+		return nil
+	}
+
+	// if node was previously initialised and is not the init command
+	if initialised && ctx.Command.Name != initCommandName {
+		var err error
+		if cfg.Name, err = dot.LoadGlobalNodeName(globalBasePath); err != nil {
+			return err
+		}
+
+		if cfg.Name != "" {
+			logger.Debug("load global node name from database", "name", cfg.Name)
+			return nil
+		}
+	}
+
+	cfg.Name = dot.RandomNodeName()
+	return nil
 }
 
 // setDotAccountConfig sets dot.AccountConfig using flag values from the cli context
@@ -736,18 +785,18 @@ func updateDotConfigFromGenesisJSONRaw(tomlCfg ctoml.Config, cfg *dot.Config) {
 	)
 }
 
-// updateDotConfigFromGenesisData updates the configuration from genesis data of an initialized node
+// updateDotConfigFromGenesisData updates the configuration from genesis data of an initialised node
 func updateDotConfigFromGenesisData(ctx *cli.Context, cfg *dot.Config) error {
-	// initialize database using data directory
+	// initialise database using data directory
 	db, err := chaindb.NewBadgerDB(&chaindb.Config{
 		DataDir: cfg.Global.BasePath,
 	})
 	if err != nil {
 		return fmt.Errorf("failed to create database: %s", err)
 	}
 
-	// load genesis data from initialized node database
-	gen, err := state.LoadGenesisData(db)
+	// load genesis data from initialised node database
+	gen, err := state.NewBaseState(db).LoadGenesisData()
 	if err != nil {
 		return fmt.Errorf("failed to load genesis data: %s", err)
 	}