Skip to content

Commit

Permalink
task(parachain): tagged async backing related issues to TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
kishansagathiya committed Oct 29, 2024
1 parent 20b85ad commit 3e1aad5
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions dot/parachain/collator-protocol/validator_side.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func (cpvs CollatorProtocolValidatorSide) Run(
}

case <-inactivityTicker.C:
// TODO: disconnect inactive peers
// TODO: disconnect inactive peers, Issue #4256
// https://github.com/paritytech/polkadot/blob/8f05479e4bd61341af69f0721e617f01cbad8bb2/node/network/collator-protocol/src/validator_side/mod.rs#L1301

case unfetchedCollation := <-cpvs.unfetchedCollation:
Expand Down Expand Up @@ -162,7 +162,7 @@ func (cpvs *CollatorProtocolValidatorSide) handleOurViewChange(view events.View)

//nolint:staticcheck
if mode.IsEnabled {
// TODO: Add it when we have async backing
// TODO: Add it when we have async backing, Issue #4253
// https://github.com/paritytech/polkadot-sdk/blob/aa68ea58f389c2aa4eefab4bf7bc7b787dd56580/polkadot/node/network/collator-protocol/src/validator_side/mod.rs#L1303 //nolint
}
}
Expand All @@ -174,7 +174,7 @@ func (cpvs *CollatorProtocolValidatorSide) handleOurViewChange(view events.View)
mode := prospectiveParachainMode()
pruned := []common.Hash{}
if mode.IsEnabled {
// TODO: Do this when we have async backing
// TODO: Do this when we have async backing, Issue #4253
// https://github.com/paritytech/polkadot-sdk/blob/aa68ea58f389c2aa4eefab4bf7bc7b787dd56580/polkadot/node/network/collator-protocol/src/validator_side/mod.rs#L1340 //nolint
} else {
pruned = append(pruned, leaf)
Expand Down Expand Up @@ -318,7 +318,7 @@ func signingKeyAndIndex(validators []parachaintypes.ValidatorID, ks keystore.Key
}

func prospectiveParachainMode() parachaintypes.ProspectiveParachainsMode {
// TODO: complete this method by calling the runtime function
// TODO: complete this method by calling the runtime function Issue #4254
// https://github.com/paritytech/polkadot-sdk/blob/aa68ea58f389c2aa4eefab4bf7bc7b787dd56580/polkadot/node/subsystem-util/src/runtime/mod.rs#L496 //nolint
// NOTE: We will return false until we have support for async backing
return parachaintypes.ProspectiveParachainsMode{
Expand Down Expand Up @@ -852,7 +852,7 @@ func (cpvs CollatorProtocolValidatorSide) processMessage(msg any) error {
cpvs.perRelayParent[msg.Parent] = perRelayParent
}

// TODO: Few more things for async backing, but we don't have async backing yet
// TODO: Few more things for async backing, but we don't have async backing yet Issue #4255
// https://github.com/paritytech/polkadot-sdk/blob/7035034710ecb9c6a786284e5f771364c520598d/polkadot/node/network/collator-protocol/src/validator_side/mod.rs#L1531-L1532
}
case collatorprotocolmessages.Backed:
Expand Down

0 comments on commit 3e1aad5

Please sign in to comment.