Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Filecoin.EthGetBlockReceiptsLimited method interface #5150

Merged
merged 6 commits into from
Jan 20, 2025

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Jan 16, 2025

Summary of changes

Changes introduced in this pull request:

  • Fix incorrect type in method prototype

Reference issue to close (if applicable)

Closes #5017

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic requested a review from a team as a code owner January 16, 2025 13:28
@elmattic elmattic requested review from hanabi1224 and LesnyRumcajs and removed request for a team January 16, 2025 13:28
@elmattic
Copy link
Contributor Author

@hanabi1224 What is the process to fix rpc_regression_tests tests?

@hanabi1224
Copy link
Contributor

@hanabi1224 What is the process to fix rpc_regression_tests tests?

@elmattic you will have to regenerate and replace the test snapshot. Instructions can be found in #5144

@hanabi1224
Copy link
Contributor

In this case the failure is transient.

@elmattic
Copy link
Contributor Author

@hanabi1224 What is the process to fix rpc_regression_tests tests?

@elmattic you will have to regenerate and replace the test snapshot. Instructions can be found in #5144

Thanks!

@hanabi1224 hanabi1224 enabled auto-merge January 20, 2025 10:06
@hanabi1224 hanabi1224 added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit af5d234 Jan 20, 2025
41 of 42 checks passed
@hanabi1224 hanabi1224 deleted the elmattic/fix-eth-get-block-receipts-limited branch January 20, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filecoin.EthGetBlockReceiptsLimited
3 participants